Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi-platform docker image support #278

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Multi-platform docker image support #278

merged 2 commits into from
Aug 26, 2024

Conversation

matheusfm
Copy link
Contributor

These changes add support for building multi-platform docker images, through the make buildx command, and bump alpine base image version.

This is how Kubebuilder generates the Makefile for generated-projects.

Closes: #253

I've built the image ghcr.io/undistro/popeye:v0.11.3 with these changes. See the supported architectures:

image

trivy image ghcr.io/undistro/popeye:v0.11.3 

2024-02-09T11:16:34.624-0300    INFO    Vulnerability scanning is enabled
2024-02-09T11:16:34.624-0300    INFO    Secret scanning is enabled
2024-02-09T11:16:34.624-0300    INFO    If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-02-09T11:16:34.624-0300    INFO    Please see also https://aquasecurity.github.io/trivy/v0.48/docs/scanner/secret/#recommendation for faster secret detection
2024-02-09T11:16:36.410-0300    INFO    Detected OS: alpine
2024-02-09T11:16:36.410-0300    WARN    This OS version is not on the EOL list: alpine 3.19
2024-02-09T11:16:36.410-0300    INFO    Detecting Alpine vulnerabilities...
2024-02-09T11:16:36.413-0300    INFO    Number of language-specific files: 1
2024-02-09T11:16:36.414-0300    INFO    Detecting gobinary vulnerabilities...

ghcr.io/undistro/popeye:v0.11.3 (alpine 3.19.1)

Total: 0 (UNKNOWN: 0, LOW: 0, MEDIUM: 0, HIGH: 0, CRITICAL: 0)

@matheusfm
Copy link
Contributor Author

Hi @derailed
Any feedback or suggestions on this?
Please let me know if there's anything I can do to help move this forward.

@eugenestarchenko
Copy link

It would be great to have this!

derailed
derailed approved these changes Aug 26, 2024
View reviewed changes
Copy link
Owner

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matheusfm Nice! Thank you for this update!

@derailed derailed merged commit e466645 into derailed:master Aug 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derailed derailed derailed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multi-platform docker image
3 participants
@matheusfm @eugenestarchenko @derailed